call controller methods directly in send duck #14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
use-controller-methods-to-create-transactions
branch
2 times, most recently
from
13d23c0 to
10cfc1e
Compare
darkwing
reviewed
Apr 19, 2022
| SWAP_TRANSACTION_TYPES.includes(transactionType) || | ||
| transactionType === TRANSACTION_TYPES.SIMPLE_SEND || | ||
| transactionType === TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER || | ||
| transactionType === TRANSACTION_TYPES.TOKEN_METHOD_TRANSFER_FROM |
There was a problem hiding this comment.
Could it be more readable if we create a var to hold all of these cases?
var VALID_TRANSACTION_TYPES = [
...SWAP_TRANSACTION_TYPES,
TRANSACTION_TYPES.SIMPLE_SEND,
// ....
]
........
!(VALID_TRANSACTION_TYPES.includes(transactionType))
There was a problem hiding this comment.
REsolved in latest
digiwand
previously approved these changes
Apr 20, 2022
ui/store/actions.js
Outdated
| txParams, | ||
| origin, | ||
| 'metamask', |
There was a problem hiding this comment.
Q: Are we certain origin can't be another value? I'm unfamiliar with where the origin(s) of origin are.
The other thing I'm wondering is if it would help to turn this into a constant value
There was a problem hiding this comment.
Probably good to use a constant. Origin is always the dapp that suggests the transaction. Because this method will only be called from within MetaMask the transaction will always originate from metamask.
brad-decker
force-pushed
the
use-controller-methods-to-create-transactions
branch
from
ba889b0 to
3ad0233
Compare
Builds ready [d41495c]Page Load Metrics (1439 ± 91 ms)
highlights:storybook
|
darkwing
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
There is no need for us to call provider methods in our send duck to create transactions, we already generate the txParams.data for transactions but strip it from the call to these provider methods so that the provider methods generate them for us. However the logic we use for generating the txParams.data in the send duck is the same as the logic these methods invoke.
This change will allow us to get a handle on the created transactionMeta and update it when necessary. We don't do that yet, but in a future PR I will add additional logging to the transaction history to show the steps that a user took to create the transaction. This will help us further debug transactions that are flagged in support tickets.
Manual testing steps